sashuk / watsonc

WatsonC Vidi extension
0 stars 2 forks source link

WatsonC Water level plot throws error then ploting two boreholes. And plot doesn't show anything #2

Closed mapcentia closed 6 years ago

mapcentia commented 6 years ago

image

sashuk commented 6 years ago

@mapcentia Fixed in https://github.com/sashuk/watsonc/commit/f48f8188af907eda07926bea2a3d5bc1f091efb0

measurements

mapcentia commented 6 years ago

@sashuk I still don't see any ploting with the new layer: image

mapcentia commented 6 years ago

@sashuk see my earlier comments. Didn't reopen

sashuk commented 6 years ago

@mapcentia Could you please set the v:sensor.sensordata_without_correction layer to be dynamically loaded?

sashuk commented 6 years ago

@mapcentia The issue is fixed (plots had no access to water level layer data) in https://github.com/sashuk/watsonc/commit/82d47f76c8b772da09eafdeaf55d7c63761fd77f, but carrying aroung the entire water level layer gets to expensive in terms of performance. The issue will be closed after testing with dynamic v:sensor.sensordata_without_correction layer.

mapcentia commented 6 years ago

@sashuk done

mapcentia commented 6 years ago

@sashuk The new layer doesn't have that many points but the time series is way bigger.

mapcentia commented 6 years ago

@sashuk It seems to work pretty good with dynamic load. When creating a plot and you pan/zoom away, so the layer refreshed with new objects, the plot goes away. I guess its because the data, which were plotted in the first place, are no longer in the browser? But is there a way to persist data? Also if you store a snapshot with a viewport far away from the plotted data?

sashuk commented 6 years ago

@mapcentia You are exactly right! Layer data can be processed following way:

  1. keep data until new portion of it is loaded after map extent change (currently used);
  2. accumulate all loaded data (used in plots) until page reload, so the plots populated after page load will always have theirs data;
  3. accumulate all loaded data (used in plots) and store it in localStorage, single data entries will be updated upon load of these entries; implement controls for clearing the stored data; implement storing of data using the stateSnapshots module;

Right now data is stored until page reload and stateSnapshots keep only references to measurements for plots, not the data itself. Should the (3) option be implemented?

sashuk commented 6 years ago

@sashuk done

Thanks, the sensor.sensordata_without_correction is now dynamic

mapcentia commented 6 years ago

@sashuk We go for option 3

sashuk commented 6 years ago

@mapcentia Got it, thanks! I will close this issue and create new one with the actual feature request then (#3).