sashuk / watsonc

WatsonC Vidi extension
0 stars 2 forks source link

GUI adjustments to 080519 test version #37

Closed JacobBirk closed 5 years ago

JacobBirk commented 5 years ago

@sashuk @mapcentia When new timeseries is generated from here image they must be automatically turned on in the dashboard and placed at first position

Right menu:

Dashboard

JacobBirk commented 5 years ago

@sashuk no data when using Chrome image

sashuk commented 5 years ago

@JacobBirk Following was fixed:

Could you please check if the following is working now (the demo with recreating both issues is presented below)?

demo1

JacobBirk commented 5 years ago

@sashuk Looks fine. The legend should include name - eg. 9.884

sashuk commented 5 years ago

@JacobBirk Could you please specify what legend should contain it? The one that is located in the right side of the Modal when the single measurement is clicked on the map?

JacobBirk commented 5 years ago

@sashuk The legend in the bottom of the timeseries DGU 9.884 - Waterlevel (meter) instead of Water level (meter), opdated ....

sashuk commented 5 years ago

@JacobBirk Got it, sure!

By the way, could you please check if the following is working now?

JacobBirk commented 5 years ago

@sashuk check where? test version?

sashuk commented 5 years ago

@JacobBirk Yes, do you have a test deployment? I am just wondering where you have observed these bugs and if it possible to recreate them.

JacobBirk commented 5 years ago

@sashuk yes https://test.watsonc.gc2.io/app/jupiter/chemicals,sensor/#geodk.bright/9/10.07/56.8495/sensor.sensordata_without_correction,chemicals.boreholes_time_series_without_chemicals

updated by Martin earlier today

here the datamenu is empty

image

JacobBirk commented 5 years ago

@sashuk I might be a good idea if you could maintain the test site/keep til the test site updated.

I have data in menu after clearing site data.

image

sashuk commented 5 years ago

@JacobBirk Thank you for the details!

Sure, I've created the same issue recently https://github.com/sashuk/watsonc/issues/40 - also I think it will be really good to have some regression tests running on every code update (the mechanism already used for Vidi in general).

sashuk commented 5 years ago

@JacobBirk I've tested the link you've provided as well, so probably the issue was that the cache was not updated. Changes in legend were implemented in https://github.com/sashuk/watsonc/commit/68220b81de296f28ab7e21ea558fff4e4d3f76ba.

plot