Closed JacobBirk closed 5 years ago
sashuk
commented
5 years ago @JacobBirk Two buttons are drawn in accordance with the material design concepts (https://material.io/design/interaction/states.html#disabled), which means that we can not click the Matrix view, for example, when it is already active - so, the button for the Matrix view should be disabled, which prevents a user from clicking it. Should this design concept be broken anyway?
Demo:
JacobBirk
commented
5 years ago @sashuk Ok. Not a big issue. Just seems non-intuitive that the chosen option is faded
sashuk
commented
5 years ago @JacobBirk Maybe just to make the faded button to have a black font color to make it more readable then?
Demo:
JacobBirk
commented
5 years ago Better 🙂
Fra: Aleksandr Shumilov notifications@github.com Sendt: 13. august 2019 07:55 Til: sashuk/watsonc watsonc@noreply.github.com Cc: Jacob Birk Jensen jbj@watsonc.dk; Mention mention@noreply.github.com Emne: Re: [sashuk/watsonc] Row versus Matrix view (#84)
@JacobBirkhttps://github.com/JacobBirk Maybe just to make the faded button to have a black font color to make it more readable then?
Demo: [color]https://user-images.githubusercontent.com/1390758/62918343-ef2c8e80-bdd1-11e9-9b78-77941dfed24a.gif
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/sashuk/watsonc/issues/84?email_source=notifications&email_token=AL7IMDL3GMS6NMI5PFPLDUDQEJED3A5CNFSM4ILAYQC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4ETYFQ#issuecomment-520698902, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AL7IMDK6PAEBC5LVB3ZRKETQEJED3ANCNFSM4ILAYQCQ.
sashuk
commented
5 years ago @mapcentia @JacobBirk Implemented in https://github.com/sashuk/watsonc/commit/7395d627d39c827bebc4b2bed8f03cf4009080d8
In the dashboard the chosen viewmode (row or matrix) is currently marked with a white button, while the non-chosen is marked with green. This should be the opposite, so that the green button marks the chosen view.