search

sasikalar / gamekit

Automatically exported from code.google.com/p/gamekit
0 stars 0 forks source link

Bullet r2456 breaks both irrkit and ogrekit build #204

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Bullet r2456 breaks both irrkit and ogrekit build.
BlenderSerialize uses operator= of btAlignedObjectArray.

Original issue reported on code.google.com by zhzhxt...@gmail.com on 17 Nov 2011 at 7:24

GoogleCodeExporter commented 9 years ago 
Can confirm this issue exists on OSX / XCode as well.

Original comment by BenT.Sol...@gmail.com on 18 Nov 2011 at 9:24

GoogleCodeExporter commented 9 years ago 
Noticed erwin had made a change to Bullet that fixes this (see GameKit forums), 
but he highlights it as an issue as it is deep-copying an array as part of a 
btHashMap template instantiation.

Do we flag this as fixed or assume that it could break in the future given 
Erwin's comments regarding the silent deep-copy and it being a bad practice 
(which I tend to agree on)?

Original comment by BenT.Sol...@gmail.com on 22 Nov 2011 at 5:18

GoogleCodeExporter commented 9 years ago 
may be it can be marked as fixed, it works now. although it is not prefect.

Original comment by zhzhxt...@gmail.com on 22 Nov 2011 at 1:47

GoogleCodeExporter commented 9 years ago 
Well, if the deep copy can be avoided somehow we should create a new issue for 
this. Actually I don't know where exactly we use it and what impact it has...

Original comment by thomas.t...@googlemail.com on 22 Nov 2011 at 10:34

GoogleCodeExporter commented 9 years ago 
XCode isn't giving me the location of the template instantiation, so I am not 
sure where in the code it is being used. One would need to use a different data 
structure for the container than btHashMap, but not knowing what I'm replacing 
or why it used a hash in the first place - I am kind of stuck looking for a 
solution.

Does it show up in Visual Studio or similar as to what is using the container?

Original comment by BenT.Sol...@gmail.com on 22 Nov 2011 at 11:00

GoogleCodeExporter commented 9 years ago 
fixed long time ago

Original comment by erwin.coumans on 12 Apr 2012 at 3:38