sasjs / adapter

An adapter for bidirectional SAS® <-> Javascript communication
https://adapter.sasjs.io
MIT License
39 stars 3 forks source link

sasjs login to sas fails when userLongName = unknown #796

Closed saramartinelli1992 closed 1 year ago

saramartinelli1992 commented 1 year ago

I'm using sasjs to connect my webapp and SAS and I recently started facing an issue. When I open my Web App, if I'm not connected the sasjs login returns userLongName = unknown as displayed in the picture below, while userName is empty

image

The fact that userLongName is not empty makes sasjs think that I'm connected and it does not appear the login mask. As a side note, if I login in another SAS app and then open my webapp, sasjs is able to correctly recognize my user

allanbowe commented 1 year ago

Thanks for raising @saramartinelli1992 - we'll investigate this asap

sabhas commented 1 year ago

@saramartinelli1992 which version of the adapter are you using? The latest version is 4.2.1. If you are not using the latest, please update the version and check if the problem persists.

saramartinelli1992 commented 1 year ago

@sabhas I was using a previous version, I now tested the lates one and I see the window for login, but it shows the following image

allanbowe commented 1 year ago

Following a call with @saramartinelli1992 we discovered that SAS9 M8 no longer redirects from SASLogon/home (but it does redirect in SAS9 M7, also Viya 4)

We did some tests and it seems the logon is consistent across versions when just using /SASLogon, we also did a build and tested this change on M8 and that worked fine. PR to follow.

Relevant commits:

allanbowe commented 1 year ago

@all-contributors please add @saramartinelli1992 for UserTesting and Platform

allcontributors[bot] commented 1 year ago

@allanbowe

I've put up a pull request to add @saramartinelli1992! :tada: