fix(deploy-service-pack): fixed redeployment - Githubissues

sasjs / adapter

An adapter for bidirectional SAS® <-> Javascript communication

https://adapter.sasjs.io

MIT License

39 stars 3 forks source link

fix(deploy-service-pack): fixed redeployment #807

Closed YuryShkoda closed 1 year ago

YuryShkoda commented 1 year ago

Issue

Closes #245 Closes #429

Intent

Fix deployServicePack when folder/file already exists.
Improve error message if the folder already exists and isForsed is falsy.

Implementation

Passed the isForsed attribute to the createFolder method.
Handled if accessToken is absent.
Improved error parsing.
Added unit test.

Checks

No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.

[x] All sasjs-cli unit tests are passing (npm test).
(CI Runs this) All sasjs-tests are passing. If you want to run it manually (instructions available here).
[x] Data Controller builds and is functional on both SAS 9 and Viya

medjedovicm commented 1 year ago

Tested on DC, works fine.