Fixed verbose mode for all response statuses - Githubissues

sasjs / adapter

An adapter for bidirectional SAS® <-> Javascript communication

https://adapter.sasjs.io

MIT License

39 stars 3 forks source link

Fixed verbose mode for all response statuses #828

Closed YuryShkoda closed 1 year ago

YuryShkoda commented 1 year ago

Issue

Related issue https://github.com/sasjs/cli/issues/1367

Intent

Handle HTTP responses with any status when RequestClient is in verbose mode.

Implementation

Added logic to handle AxiosError in defaultInterceptionCallBack method with fallback options.
Covered defaultInterceptionCallBack method with unit tests mocking responses with random statuses from 1** to 5**.
Fixed typo in src/api/viya/executeScript.ts.
Set unit test coverage threshold and updated .github/PULL_REQUEST_TEMPLATE.md.

Checks

No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.

[x] All sasjs-cli unit tests are passing (npm test).
(CI Runs this) All sasjs-tests are passing. If you want to run it manually (instructions available here).
[ ] Data Controller builds and is functional on both SAS 9 and Viya

github-actions[bot] commented 1 year ago

Coverage report

Total coverage

Status	Category	Percentage	Covered / Total
🟡	Statements	63.66%	2104/3305
🔴	Branches	44.75%	767/1714
🔴	Functions	53.94%	308/571
🟡	Lines	74.14%	3409/4598

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 259b6b3ff2679f04641e768c6f2d8c800ac24556