fix(execute-script): fixed executing jobs on viya using compute api - Githubissues

sasjs / adapter

An adapter for bidirectional SAS® <-> Javascript communication

https://adapter.sasjs.io

MIT License

39 stars 3 forks source link

fix(execute-script): fixed executing jobs on viya using compute api #830

Closed YuryShkoda closed 1 year ago

YuryShkoda commented 1 year ago

Issue

Closes #829

Intent

Job arguments don't make sense during the execution of a SAS job using compute API and should not be part of the request body.

Implementation

Renamed executeScript to executeOnComputeApi.
Removed jobArguments from the request body in src/api/viya/executeOnComputeApi.ts.
Adjusted unit tests in src/api/viya/spec/executeScript.spec.ts.

Checks

No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.

[x] Unit tests coverage has been increased and a new threshold is set.
[x] All sasjs-cli unit tests are passing (npm test).
(CI Runs this) All sasjs-tests are passing. If you want to run it manually (instructions available here).
[ ] Data Controller builds and is functional on both SAS 9 and Viya