feat(job-state): added session state check to doPoll func - Githubissues

sasjs / adapter

An adapter for bidirectional SAS® <-> Javascript communication

https://adapter.sasjs.io

MIT License

39 stars 3 forks source link

feat(job-state): added session state check to doPoll func #832

Closed YuryShkoda closed 1 year ago

YuryShkoda commented 1 year ago

Issue

Sometimes SAS API returns the job state running when the parent session is not in a running state.

Intent

Periodically (every 10th job state poll) check parent session state.

Implementation

Added parent session state check to doPoll function located at src/api/viya/pollJobState.ts.
Adjusted src/api/viya/executeOnComputeApi.ts
Refactored src/SessionManager.ts.
Adjusted existing unit tests and covered new functionality.
Updated unit test threshold.

Checks

No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.

[x] Unit tests coverage has been increased and a new threshold is set.
[x] All sasjs-cli unit tests are passing (npm test).
(CI Runs this) All sasjs-tests are passing. If you want to run it manually (instructions available here).
[ ] Data Controller builds and is functional on both SAS 9 and Viya