search

sasjs / adapter

An adapter for bidirectional SAS® <-> Javascript communication
https://adapter.sasjs.io
MIT License
39 stars 3 forks source link

Login window closes when phrase "You have signed in." is shown - only works for English browser setting #835

Closed gh4nh closed 4 months ago

gh4nh commented 4 months ago

Expected behaviour

When a user logs on the pop-up should be closed when the login process is completed

Current behaviour

The login pop-up closes only when the browser language is set to English, for any other language the code can not find the phrase "You have signed in."

Environment info

Client tech stack: VanillaJS, NodeJS etc. Server type: SASJS|SASVIYA|SAS9 Login mechanism: Redirected Debug: false

In https://[cdn.jsdelivr.net/npm/@sasjs/adapter@4/index.min.js](https://cdn.jsdelivr.net/npm/@sasjs/adapter@4/index.min.js) e.g. a.includes("You have signed in.") and t.window.document.body.innerText.includes("You have signed in.")

allanbowe commented 4 months ago

@gh4nh - thanks for raising this. Right now we do not have a SAS Viya environment available to us. However this could be easy to fix for your use case, if you can provide us the "You have signed in" language snippet for your preferred locale(s)?

Agreed (in advance) that it should not be language dependent. Once our team gets another Viya project we can take a look at implementing a more robust approach.

gh4nh commented 4 months ago

Hi Allan, please find attached the snippets from a SAS9 environment. SAS9 is currently my focus. I'll look today for the Viya4 equivalent. sas9_you_have_signed.txt

Thank you, Niko

allanbowe commented 4 months ago

@gh4nh - please confirm if the new version is now working ok for your locale