need to use --legacy-peer-deps to run npm install

rudvfaden commented 2 years ago

I need to use --legacy-peer-deps when I run npm installto get the app to work. Is there a way to fix that?

allanbowe commented 2 years ago

Hi Rud - when did you clone the repo?

Do you have this file in your project? https://github.com/sasjs/angular-seed-app/blob/main/.npmrc

rudvfaden commented 2 years ago

Yes

rudvfaden commented 2 years ago

I tried creating a new app using the sas cli. It work without issues.

The angular version is however 13 in the template. The current version is 14. Should i update angular to version 14 when i create the project or will it breake?

allanbowe commented 2 years ago

Hi @rudvfaden - we've bumped both clarity and angular, and the legacy peer deps should not longer be needed.

Are you able to re-clone (or re-create using CLI) and confirm?

rudvfaden commented 2 years ago

Got this error when trying to use npm install. Used sasjs create --template angular.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @clr/angular@13.5.0
npm ERR! Found: @angular/common@14.1.0
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"^14.1.0" from the root project
npm ERR!   peer @angular/common@"^13.0.0 || ^14.0.0-0" from @angular/cdk@13.3.9
npm ERR!   node_modules/@angular/cdk
npm ERR!     @angular/cdk@"^13.3.8" from the root project
npm ERR!   4 more (@angular/forms, @angular/platform-browser, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^13.0.0" from @clr/angular@13.5.0
npm ERR! node_modules/@clr/angular
npm ERR!   @clr/angular@"^13.5.0" from the root project
npm ERR!   peer @clr/angular@"13.5.0" from @clr/ui@13.5.0
npm ERR!   node_modules/@clr/ui
npm ERR!     @clr/ui@"13.5.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @angular/common@13.3.11
npm ERR! node_modules/@angular/common
npm ERR!   peer @angular/common@"^13.0.0" from @clr/angular@13.5.0
npm ERR!   node_modules/@clr/angular
npm ERR!     @clr/angular@"^13.5.0" from the root project
npm ERR!     peer @clr/angular@"13.5.0" from @clr/ui@13.5.0
npm ERR!     node_modules/@clr/ui
npm ERR!       @clr/ui@"13.5.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/JB4555/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/JB4555/.npm/_logs/2022-07-21T13_35_28_160Z-debug-0.log

medjedovicm commented 2 years ago

I investigated more, and the issue is in @clr/angular library.

@rudvfaden Can you confirm your steps:

sasjs create --template angular
npm install

Is that correct?

If so, in the npm install step as a workaround you just call this:

npm install --legacy-peer-deps

Please do let me know if that worked for you.

rudvfaden commented 2 years ago

Yes. The steps are correct.

tor. 21. jul. 2022 15.51 skrev Mihajlo Medjedovic @.***

:

I investigated more, and the issue is in @clr/angular library.

@rudvfaden https://github.com/rudvfaden Can you confirm your steps:

sasjs create --template angular

npm install

Is that correct?

If so, in the npm install step as a workaround you just call this:

npm install --legacy-peer-deps

— Reply to this email directly, view it on GitHub https://github.com/sasjs/angular-seed-app/issues/654#issuecomment-1191512693, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASVCCI7WEGC4JEAWTMM373VVFIWFANCNFSM54GZ6PAA . You are receiving this because you were mentioned.Message ID: @.***>

medjedovicm commented 2 years ago

@rudvfaden Ok great, sorry for the small delay, I misinterpreted the issue at first, should've suggested that flag right away.

allanbowe commented 2 years ago

@rudvfaden - I'm going to re-open this issue. We can't support the removal of the --legacy-peer-deps option due to it not being supported by our dependency: @clr/angular

So in the meantime we recommend re-setting the flag in .npmrc, apologies for the run-around

rudvfaden commented 2 years ago

Weirdly it worked before you made any changes when I created the app with sasjs cli.

But I am looking forward to a solution.

On Thu, Jul 21, 2022 at 5:02 PM Allan Bowe @.***> wrote:

@rudvfaden https://github.com/rudvfaden - I'm going to re-open this issue. We can't support the removal of the --legacy-peer-deps option due to it not being supported by our dependency: @clr/angular

So in the meantime we recommend re-setting the flag in .npmrc, apologies for the run-around

— Reply to this email directly, view it on GitHub https://github.com/sasjs/angular-seed-app/issues/654#issuecomment-1191594968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASVCCKTITIZGF2YEWKVGG3VVFQ7JANCNFSM54GZ6PAA . You are receiving this because you were mentioned.Message ID: @.***>

-- Rud Faden +45 22 51 07 02

allanbowe commented 2 years ago

Hi Rud - this should be resolved once the Clarity framework updates to Angular 14, see this issue: https://github.com/vmware-clarity/ng-clarity/issues/95

In particular, this comment: https://github.com/vmware-clarity/ng-clarity/issues/95#issuecomment-1155392789