search

sasjs / cli

Command line interface for creating, compiling, and building SAS® projects
https://cli.sasjs.io
MIT License
37 stars 5 forks source link

`sasjs build` should base64 encode files to ensure the JSON is fully self contained #1013

Closed allanbowe closed 3 years ago

allanbowe commented 3 years ago

With the work we did for streaming apps, the JSON produced by sasjs build was updated to enable files to be uploaded to both SAS 9 and Viya

The issue is that this was implemented using file path pointers, which means the JSON file is no longer portable

This is a problem when deploying the build JSON as part of a web pack bundle

To fix this, as part of sasjs build we should base64 encode files into the JSON file itself, making a single portable file for deployments.

A test for this should be included within the adapter repo (or sasjs-tests)

allanbowe commented 3 years ago

(This ticket should have been in the CLI repo!)

allanbowe commented 3 years ago

Closed in https://github.com/sasjs/cli/pull/855