sasjs / cli

Command line interface for creating, compiling, and building SAS® projects
https://cli.sasjs.io
MIT License
37 stars 5 forks source link

fix image rendering in streamed apps on Viya 4 #1309

Closed allanbowe closed 1 year ago

allanbowe commented 1 year ago

Currently when deploying images as part of a streamed app, they are not returned correctly, likely due to API changes in Viya 4.

checking the details in a "successfully returned" image (loaded with SAS Drive) and an unsuccessful one, the differences are:

unsuccessful successful
"contentDisposition": "filename=\"player.png\";", "contentDisposition": "attachment;filename*=UTF-8''sonic.png",
"typeDefName": "file", "typeDefName": "file_png",

It's likely to be the typeDefName value causing the issue

allanbowe commented 1 year ago

List of available typeDefName values available here: https://gist.github.com/allanbowe/32a47a78e386b3517dd22f292108f2f9

sabhas commented 1 year ago

via Hubstaff User: Sabir Hassan

Project: SASjs cli - https://app.hubstaff.com/projects/2310875 Date Range: 01/13/23 - 01/17/23 Work session total: 21:01:10 Billable: Yes

Grand total: 21:01:10

sasjsbot commented 1 year ago

:tada: This issue has been resolved in version 3.26.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: