npm WARN deprecated querystring@0.2.0

sasjs / cli

Command line interface for creating, compiling, and building SAS® projects

https://cli.sasjs.io

MIT License

37 stars 5 forks source link

Closed allanbowe closed 3 years ago

allanbowe commented 3 years ago

We are getting the following warning when installing the CLI:

npm WARN deprecated querystring@0.2.0:

Expected behaviour - the CLI should install with zero warnings or errors

jimmywarting commented 3 years ago

guess you are suppose to report it to https://github.com/sasjs/adapter that have a dependency on url that looks like it is not being used?

allanbowe commented 3 years ago

Quite right @jimmywarting, thanks for the spot! We have an adapter PR underway, @saadjutt01 is investigating.

allanbowe commented 3 years ago

For reference, here is the PR that deprecated querystring: https://github.com/Gozala/querystring/pull/52

As per the homepage:

The querystring API is considered Legacy. new code should use the URLSearchParams API instead.