feat: removed secrets from env variables - Githubissues

sasjs / server

Build Apps on Base SAS

https://server.sasjs.io

MIT License

20 stars 3 forks source link

feat: removed secrets from env variables #220

Closed saadjutt01 closed 2 years ago

saadjutt01 commented 2 years ago

Issue

Closes #213

Intent

All the secrets should be saved in DB, auto-generated and if already present, load them on server start.

Implementation

Moved ACCESS_TOKEN_SECRET, REFRESH_TOKEN_SECRET, AUTH_CODE_SECRET, SESSION_SECRET from process.env to process.secrets

On startup:

loaded from DB
if not present, generated and saved to DB
then set to process.secrets

Updated seedDB.ts accordingly

Checks

[x] Code is formatted correctly (npm run lint:fix).
[ ] Any new functionality has been unit tested.
[x] All unit tests are passing (npm test).
[x] All CI checks are green.
[ ] Reviewer is assigned.

ghost commented 2 years ago

:tada: This PR is included in version 0.9.0 :tada:

The release is available on:

GitHub release
v0.9.0

Your semantic-release bot :package::rocket: