sasjs / server

Build Apps on Base SAS
https://server.sasjs.io
MIT License
20 stars 3 forks source link

update to POST request format #258

Closed allanbowe closed 2 years ago

allanbowe commented 2 years ago

Currently, POST requests to the /SASjsApi/stp/execute will always return a JSON object. This has the benefit of being easy to parse by client apps, however it also has a serious performance impact for larger payloads, eg:

To illustrate - the request below took 2.5 minutes to generate, then 18 seconds to download (16mb):

image

The Proposal:

  1. Send back the raw value of webout.txt directly in the response
  2. Append the log if DEBUG >0 or if the SAS executable returned a non-0 response
  3. Use a separator to distinguish the two in the response (to be determined)

This will require corresponding updates in the Adapter and other SASjs-linked applications.

sasjsbot commented 2 years ago

:tada: This issue has been resolved in version 0.16.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: