Cli issue 1227 - Githubissues

sasjs / utils

Utility functions and helpers for the SASjs framework

https://sasjs.io

8 stars 0 forks source link

Cli issue 1227 #196

Closed YuryShkoda closed 2 years ago

YuryShkoda commented 2 years ago

Issue

https://github.com/sasjs/cli/issues/1227

Intent

Improve removeHeader utility.
Introduce new SASJsFileType File.

Implementation

Improved RegExp used in removeHeader and covered by unit tests.
Added File to SASJsFileType enum.
Added logic to loadDependenciesFile for SASJsFileType.file.

Checks

[x] Code is formatted correctly (npm run lint:fix).
[x] All unit tests are passing (npm test).
[ ] All sasjs-cli unit tests are passing (npm test).
[x] Reviewer is assigned.

YuryShkoda commented 2 years ago

Some questions:

What caused the linting changes?

What is 'wrapping' ?

What was the reason for the new 'file' type? Where is it used?

The wrong version of prettier has been used in my local environment.
and 3. I'll improve comments

ghost commented 2 years ago

:tada: This PR is included in version 2.46.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: