Target url issue - Githubissues

sasjs / vscode-extension

SAS Linting, Syntax Highlighting, and Code Execution from VS Code

https://marketplace.visualstudio.com/items?itemName=SASjs.sasjs-for-vscode

MIT License

22 stars 4 forks source link

Target url issue #414

Closed YuryShkoda closed 1 year ago

YuryShkoda commented 1 year ago

Issue

Server URL with port number was incorrectly added while target creation.
Line commenting implemented in @sasjs/vscode-extension was not limited to .sas files only.

Intent

Fix adding server URL with a port number.
Use @sasjs/utils for URL validation.
Allow adding target with server URL equal to an empty string.
Add unit tests.
Limit addRemoveComment to be triggered only for .sas files.

Implementation

Removed valid-url dependency and bumped @sasjs/cli and @sasjs/utils.
Handled authentication error in src/utils/createTarget.ts and covered with unit test.
Changed logic of getServerUrl func and covered with unit test.

Checks

[x] Code is formatted correctly (npm run lint).
[x] All unit tests are passing (npm run test:unit).
[x] Reviewer is assigned.

sasjsbot commented 1 year ago

:tada: This PR is included in version 2.4.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: