sass / dart-sass

The reference implementation of Sass, written in Dart.
https://sass-lang.com/dart-sass
MIT License
3.97k stars 357 forks source link

Dart Sass + Jekyll 4.3.2 + Canonical Vanilla-Framework 3.1.4 #1949

Closed oDinZu closed 1 year ago

oDinZu commented 1 year ago

I tested https://talk.jekyllrb.com/t/making-use-of-vanilla-framework-without-npm-for-jekyll-scss/8213 Ubuntu's vanilla framework 3.1.4 and had all kinds of sassy errors like math.div and interpolation with hsl.

I tested on with the latest jekyll-sass-converter 2.1 with Jekyll 4.2.2 and 4.3.2.

If it helps, I had the following errors with the latest stable release of ubuntu vanilla-framework.

https://github.com/canonical/vanilla-framework/issues/4757

I am unsure what Dart Sass version Jekyll is using, I assume it is 1.6.2. Related: https://github.com/jekyll/jekyll-sass-converter/issues/152

ntkme commented 1 year ago

You were not even using Dart Sass.

oDinZu commented 1 year ago

Thank you @ntkme

It seems I tested both versions and encountered the same issues. I would have to reintegrate that css framework again to test it and make sure, but I have already moved on to another framework that actually compiles with Jekyll 3.0 Scss.

ntkme commented 1 year ago

@csharpee Another issue to keep in mind is that the classic github-pages flow is locked to use jekyll-sass-converter 1.5.2 (it ignores your Gemfile/Gemfile.lock). If you want to use github-pages you need to use GitHub Action to build your page.