search

sass / dart-sass

The reference implementation of Sass, written in Dart.
https://sass-lang.com/dart-sass
MIT License
3.9k stars 352 forks source link

Fix linux musl builds #2175

Closed ntkme closed 7 months ago

ntkme commented 7 months ago
ntkme commented 7 months ago

I noticed that this is a potential breaking change for downloading script in embedded-host-node: https://github.com/sass/embedded-host-node/blob/6944074bb227660883253d2c57183301dd1bd1d6/tool/prepare-optional-release.ts#L172-L179

This is because we used to have linux-musl-arm64 and now it's linux-arm64-musl.

@nex3 Shall we change cli_pkg or the download script in embedded-host-node?

nex3 commented 7 months ago

I think we should fix it in the embedded host (which it looks like your PR already does), at least partly because changing cli_pkg now would technically be a breaking change.