sass-embedded <1.59.2 would be broken if a windows user upgrades to the latest node with the fix for the CVE. There is no security risk for sass-embedded itself even if a windows user uses a vulnerable version of node, because we don't have any arguments when launching .bat, thus there is no risk of injection with in this project. However, there might be attack factors in other node dependencies, therefore, it is recommended for windows users to upgrade to latest node and sass-embedded >=1.59.2.
Test is broken because we use the .bat wrapper in the test, this is now blocked with the CVE fix. This PR fixes this case by adding shell: true.
This is mainly a test-only fix:
sass-embedded >=1.59.2is not affected because in production release we always launch thedart.exedirectly since this commit: https://github.com/sass/embedded-host-node/commit/308862033e00f7a28a83c3114941efb053c395f6sass-embedded <1.59.2would be broken if a windows user upgrades to the latest node with the fix for the CVE. There is no security risk forsass-embeddeditself even if a windows user uses a vulnerable version of node, because we don't have any arguments when launching.bat, thus there is no risk of injection with in this project. However, there might be attack factors in other node dependencies, therefore, it is recommended for windows users to upgrade to latest node andsass-embedded >=1.59.2..batwrapper in the test, this is now blocked with the CVE fix. This PR fixes this case by addingshell: true.