sass / libsass

A C/C++ implementation of a Sass compiler
https://sass-lang.com/libsass
Other
4.33k stars 462 forks source link

Error: malformed URL #2637

Open Taritsyn opened 6 years ago

Taritsyn commented 6 years ago

Problem appeared after upgrading to version 3.5.3.

input.sass

@import url(http://fonts.googleapis.com/css?family=Limelight&subset=latin,latin-ext)

Actual results

The following error occurs:

Error: malformed URL
        on line 1 of ../../../../SharedFiles/import/sass/input.sass
>> @import url(http://fonts.googleapis.com/css?family=Limelight&subset=latin,"l
   --------^

This error is caused by presence of comma in the URL and is typical only for indented syntax.

Expected result

@import url(http://fonts.googleapis.com/css?family=Limelight&subset=latin,latin-ext);
nschonni commented 6 years ago

Looks like it may be related to the sass2scss bump in https://github.com/sass/libsass/commit/ca89d73e84616a87e64febb93afaa0bd70ef181d Not sure, just looked through the 3.5.2 to 3.5.3 diff and it seems to be the only thing related. Appears only to be an indented syntax issue

xzyfer commented 6 years ago

cc @mgreter

On Wed., 25 Apr. 2018, 12:35 pm Nick Schonning, notifications@github.com wrote:

Looks like it may be related to the sass2scss bump in ca89d73 https://github.com/sass/libsass/commit/ca89d73e84616a87e64febb93afaa0bd70ef181d Not sure, just looked through the 3.5.2 to 3.5.3 diff and it seems to be the only thing related. Appears only to be an indented syntax issue

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sass/libsass/issues/2637#issuecomment-384142621, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjZWOZ7b4Y0Ukb6k8pPZ9slp__U_2Uaks5tr-D4gaJpZM4TiLB3 .

xzyfer commented 6 years ago

As a work around I've released 3.5.4 which the sass2scss bump reverted since we need to get the node-sass release out.

Taritsyn commented 5 years ago

This error is again relevant in version 3.6.0.

Taritsyn commented 5 years ago

I created the PR with fixes for this error in the sass2scss repository.