sass / migrator

Tool for migrating stylesheets to new Sass versions
MIT License
89 stars 11 forks source link

Support @extend in the module migrator #120

Open jathak opened 5 years ago

jathak commented 5 years ago

The migrator should add additional @use rules to ensure that selectors being extended are upstream of the extending selector.

An internal team ran into this issue when migrating. The compiler saved them for extended placeholder selectors, but not for a concrete selector that was also present within the same stylesheet as the @extend (which they didn't notice until their screenshot tests failed).

jathak commented 5 years ago

@nex3: Do you know what the right way to go about doing this would be? Would having References track extensions make sense?

nex3 commented 5 years ago

That sounds like a reasonable place to start, yeah.