search

sass / node-sass

:rainbow: Node.js bindings to libsass
https://npmjs.org/package/node-sass
MIT License
8.51k stars 1.32k forks source link

sunos Support #36

Closed Fauntleroy closed 11 years ago

Fauntleroy commented 11 years ago

Tried to deploy my application running node-sass earlier when this problem cropped up:

error:   Error: Cannot find module '/opt/haibu/apps/fauntleroy/tandemdraw/package/node_modules/igneous/node_modules/node
-sass/precompiled/sunos-x64/binding'
error:       at Function.Module._resolveFilename (module.js:338:15)
error:       at Function.Module._load (module.js:280:25)
error:       at Module.require (module.js:362:17)
error:       at require (module.js:378:17)
error:       at Object.<anonymous> (/opt/haibu/apps/fauntleroy/tandemdraw/package/node_modules/igneous/node_modules/node
-sass/sass.js:11:13)
error:       at Module._compile (module.js:449:26)
error:       at Object.Module._extensions..js (module.js:467:10)
error:       at Module.load (module.js:356:32)
error:       at Function.Module._load (module.js:312:12)
error:       at Module.require (module.js:362:17)

A quick glance at the precompiled folder reveals that there's nothing there for sunos. Any chance we could get it? Alternatively, is there some way node-sass could attempt to compile when no precompiled files are available?

deanmao commented 11 years ago

yeah, just run "node-gyp recompile" and it should build a version for your OS.

Fauntleroy commented 11 years ago

Good to know, but I don't think I can get direct access to this particular box (deploying on nodejitsu)

deanmao commented 11 years ago

Well, if you compile it and do a pull request, we can put the precompiled binary into the official npm package for you.

deanmao commented 11 years ago

any leads on this yet? I don't have access to a sunos box to compile this binary.

Fauntleroy commented 11 years ago

I don't have access to the box itself, so I can't really compile it. Is there some way this module can attempt to compile if no precompiled package exists?

nijikokun commented 11 years ago

I have gone a step further with the help of AvianFlu and figured out how to get it to actually attempt to build on nodejitsu sunos server box: https://github.com/parsify/node-sass/commit/749d846b596ff4a898929a2cd334c806e74a0eb9

Unfortunately you still get errors: https://gist.github.com/d86d094666053da82f85

deanmao commented 11 years ago

@Nijikokun It should work now... there was some code in master that prevented it from compiling. If you do get it compiling on sunos, fetch us the binary and do a pull request so we can help out those people running on joyent boxes.

blakmatrix commented 11 years ago

@deanmao I am getting this currently attempting to compile on a sunos box, any ideas ? https://gist.github.com/blakmatrix/5051225

deanmao commented 11 years ago

Yeah, we have a check in bindings.gyp where we add that flag but right now it only adds that flag if it's linux. We need to modify bindings.gyp to also add that flag if it's sunos. Maybe you can hack it in to see if it compiles fine? I don't have a sunos machine here to test it on.

blakmatrix commented 11 years ago

@deanmao @Fauntleroy @andrew https://github.com/andrew/node-sass/pull/64 should fix this issue.

deanmao commented 11 years ago

Is this fixed? I'm closing the bug if so.