search

sass / sassc-ruby

Use libsass with Ruby!
MIT License
366 stars 156 forks source link

disable lto flag for darwin + nix #166

Closed michaelglass closed 4 years ago

michaelglass commented 4 years ago

darwin nix's clang doesn't support -lto

this PR disables -lto flag for darwin + nix

see https://github.com/sass/sassc-ruby/issues/148 for more context

lrworth commented 4 years ago

It'd be awesome if this got merged, just saying.

lavoiesl commented 4 years ago

I’m also experiencing this problem.

Better lto detection would be great, but this is a non-intrusive fix and would unblock other people.

bolandrm commented 4 years ago

@glebm could you please review this PR?

lrworth commented 4 years ago

I haven't tested this version - does it work? https://github.com/sass/sassc-ruby/pull/192 makes more sense to me.