sass / sassc-ruby

Use libsass with Ruby!
MIT License
367 stars 156 forks source link

Honour global CFLAGS and CXXFLAGS? #177

Open ashenm opened 4 years ago

ashenm commented 4 years ago

The optimisations tunes introduced in commit https://github.com/sass/sassc-ruby/commit/5f98917e5cdaf3ee3b9b0c9ce26878cc7320a4fb unfortunately breaks the portability between different processor architectures causing issues such as #146

While this issue could be mitigated by simply reinstalling with the build option --disable-march-tune-native or thereof, in instances where sassc-ruby being installed as a dependency of another package such as jekyll, the complication isn't obvious at first and requires additional manoeuvres.

Hence, will it be adequate and reasonable to take into consideration the already set CFLAG/CXXFLAGS global variables or a variant thereof in ext/extconf.rb while generating the Makefile?

ashenm commented 4 years ago

Correlates with #158 #175