search

sass / sassc-ruby

Use libsass with Ruby!
MIT License
363 stars 157 forks source link

Fix rake gem:native task #196

Closed casperisfine closed 4 years ago

casperisfine commented 4 years ago

As discussed in https://github.com/sass/sassc-ruby/issues/195, rake gem:native is currently broken, preventing a new release.

The error is:

Package g++-multilib is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'g++-multilib' has no installation candidate
rake aborted!

I looked around and apparently this package is outdated an no longer available. However it's used for cross compiling for 32bit packages.

If we looked at downloaded packages:

I think it's safe to say that close to nobody downloads the 32 bits binaries, and for the few people who do, AFAIK it should fallback somewhat nicely to compiling from source.

All that to say that I think it's OK to drop it.

cc @bolandrm @rafaelfranca

casperisfine commented 4 years ago

Additionally f26f2a1febf93165256fbbc58d1f9019fd05d26f removed precompilation for linux, so really the only precompilation left is x64-mingw32.

I tested it locally and it works:

$ ls pkg/
sassc-2.2.1-x64-mingw32     sassc-2.2.1-x64-mingw32.gem sassc-2.2.1.gem
glebm commented 4 years ago

A better fix would be to remove this install command:

https://github.com/sass/sassc-ruby/blob/0cb5c9e635bf94707c920227d4bd20c51e37922a/Rakefile#L41

This is now handled in rake-compiler itself

casperisfine commented 4 years ago

Well, that's what this PR does.

I pushed a new commit that adds x86-mingw32 back.

glebm commented 4 years ago

Please update the commit message as well

casperisfine commented 4 years ago

Please update the commit message as well

RIght, good point. Done.

bolandrm commented 4 years ago

Thanks. Will release tomorrow morning assuming i don't run into any issues.

bolandrm commented 4 years ago

Release complete, thanks for the help!