search

sass / sassc-ruby

Use libsass with Ruby!
MIT License
366 stars 156 forks source link

Update libsass to 3.6.4 #199

Closed ahorek closed 4 years ago

ahorek commented 4 years ago

https://github.com/sass/libsass/releases/tag/3.6.4

fixes https://github.com/sass/sassc-ruby/issues/198

toncid commented 4 years ago

This is a straightforward change. Any chances of pushing this update?

lxxxvi commented 4 years ago

Hello, I don't know much about libsass and and/or this gem, but I encountered a problem in one of my projects (Rails) with sassc version v2.3.0.

The problem appears in the rake task assets:precompile where sassc is called (I guess). On Mac OS X (10.15.4, Catalina) the process runs forever for no apparent reason and has to be killed manually. On CI (Ubuntu 16.04) I actually get an error 

*** Error in `ruby': corrupted size vs. prev_size: 0x0000000006d44810 ***
======= Backtrace: =========

/lib/x86_64-linux-gnu/libc.so.6(+0x777e5)[0x7fbd888c17e5]

/lib/x86_64-linux-gnu/libc.so.6(+0x7e9dc)[0x7fbd888c89dc]

/lib/x86_64-linux-gnu/libc.so.6(+0x81cde)[0x7fbd888cbcde]

/lib/x86_64-linux-gnu/libc.so.6(__libc_malloc+0x54)[0x7fbd888ce184]

/usr/lib/x86_64-linux-gnu/libstdc++.so.6(_Znwm+0x18)[0x7fbd7700be78]

/home/travis/build/[user]/[project]vendor/bundle/ruby/2.6.0/bundler/gems/sassc-ruby-1bc1c545f38a/lib/sassc
#  DO YOU NEED MORE ?

...including a "Backtrace" and "Memory map" (I am not sure if it's relevant to post the full output here).

After some desperate experiments, I found that libsass 3.6.4 addressed an issue that caused a "massive memory leak", so I installed this branch from @ahorek and then the rake task worked again.

May be worth mentioning is that I spotted the problem when running rails test and the process didn't seem to start since the assets:precompilation got stuck in the "memory"-problem.

Also: In the project I use Foundation CSS framework, which could be a trigger for the problem.

In conclusion: I am looking forward to seeing a new version of this gem ;-)