search

sassafrastech / rcredits-mobile

Mobile application for rCredits
0 stars 2 forks source link

3790 replace strings #8

Closed emitche closed 8 years ago

emitche commented 8 years ago

Replaces existing strings in app and uses translate service

emitche commented 8 years ago

For template consistency, title (and subtitle, if needed), were being passed through the controller and not the view. As the translate service is set up, if the text to be displayed needs to display a scoped variable, the translate service cannot accept that scope. It would be good to be able to pass scopes to the translate service through the controller. But that may not be possible.

smoyte commented 8 years ago

Looking great. Just a few comments and you can merge.