🧼 JavaScript Standard Style Fix & Super-linter Action

sassansh / Places

A M.E.R.N. full-stack application to help trusted groups find the best places to visit

https://places-cpsc455.herokuapp.com/

MIT License

1 stars 3 forks source link

🧼 JavaScript Standard Style Fix & Super-linter Action #120

Closed sassansh closed 3 years ago

sassansh commented 3 years ago

🎨 Cleaned up a lot of css code style issues
🤖 Used npx semistandard --fix to fix a lot of javascript code style issues (https://github.com/standard/semistandard)
🚔 Setup an auto lint action to show us style issues on changed files when pull request on main happens.
- Super-linter action

sassansh commented 3 years ago

Isn't it good coding practice to have a semi colon at the end of a line?

All the semi colons are being deleted.

I found that weird as well. I thought they were required. Turns out they are optional and code looks a lot cleaner without them. https://flaviocopes.com/javascript-automatic-semicolon-insertion/

Let me know your thoughts.

sassansh commented 3 years ago

Check out this section on their own website:

I disagree with rule X, can you change it? No. The whole point of standard is to save you time by avoiding bikeshedding about code style. There are lots of debates online about tabs vs. spaces, etc. that will never be resolved. These debates just distract from getting stuff done. At the end of the day you have to 'just pick something', and that's the whole philosophy of standard -- its a bunch of sensible 'just pick something' opinions. Hopefully, users see the value in that over defending their own opinions.

https://standardjs.com/#i-disagree-with-rule-x-can-you-change-it

sassansh commented 3 years ago

You win @johnnybcs! semicolons are back! Our lint actions wont complain anymore. All checks passing.

sassansh commented 3 years ago

Awesome! Going forward all of our code is linted for any obvious issues, I have fixed all existing issues.

🆕 ⚠️ Required: These 2 checks must pass to be able to merge going forward:

Lint Code Base
Test Frontend Build @amirjfr @johnnybcs @laurarodgers