search

sassansh / Places

A M.E.R.N. full-stack application to help trusted groups find the best places to visit
https://places-cpsc455.herokuapp.com/
MIT License
1 stars 3 forks source link

PlaceView supports custom #122

Closed laurarodgers closed 3 years ago

laurarodgers commented 3 years ago

PlaceView supports custom criteria, calculates averages using array rating.

sassansh commented 3 years ago

Such an elegant design! Absolutely love it. 🤩 Fix the lint issues and merge 👍🏻 image

laurarodgers commented 3 years ago

The linter thinks Ant props like flex="0 0" are zeros with units, which is a real irritant

Also not loving how 2.45 rounds to 2, not 2.5 according to Ant Rate, what even is that, do we need to hard round in advance each time or use a custom version of rate

sassansh commented 3 years ago

Also not loving how 2.45 rounds to 2, not 2.5 according to Ant Rate, what even is that, do we need to hard round in advance each time or use a custom version of rate

I know, I found that weird too. But I looked at Amazon. They do it the same way as ant as well. They round down to the closest .5 rating. So it’s pretty standard. It should be ok.

Edit: Never mind. They do round up sometimes too: image image

laurarodgers commented 3 years ago

Decided to help out and fix the lint issues :) Let me know if you have any questions! Its ready to be merged ✅

Amazing job! 👏🏻

Please don't do this. I don't know how else to phrase it. Please don't push commits to branches that literally have other people's names on them. It makes it very difficult to do my own work on my own branch.