Closed sassansh closed 3 years ago
what is this?
That shouldnt happen easily unless you click submit over and over again. What are the steps to reproduce that issue?
I clicked the submit button over and over like a maniac!
I clicked the submit button over and over like a maniac!
Is that really a use case we need to worry about though?
Can we make a change directly to the AddReview page so that:
a) if a rate is set to less than 1 star, it is automatically changed onchange to 1 star b) the option in the Ant Rate component that clears the Rate when clicking it twice is disabled
regarding a, do you mean the default value should be 1? Or that when they submit with a rating 0 zero they change to 1 and submit?
Can we make a change directly to the AddReview page so that: a) if a rate is set to less than 1 star, it is automatically changed onchange to 1 star b) the option in the Ant Rate component that clears the Rate when clicking it twice is disabled
regarding a, do you mean the default value should be 1? Or that when they submit with a rating 0 zero they change to 1 and submit
I tried this out in staging and I realize that we're currently using 0 for a "blank/not yet rated" state, and the issue is it is was also being accepted as a genuine rating value.
I think we should keep using 0 as a "blank/not yet rated" state and have the error message say "please enter a rating"? or "please enter a rating for all criteria"???
so you've convinced me we shouldn't do the onchange to 1 star or default to 1 star
but we should disable the Ant thing that changes the rating value to 0 if you click the component twice
Alright changes made:
Im not sure why the checks arent running, maybe because @laurarodgers you requested changes?
Im not sure why the checks arent running, maybe because @laurarodgers you requested changes?
Yeah that's what I suspect, which is weird, I wanted to look at it on staging before accepting but I can't because I haven't accepted? Chicken and egg problem lol
Github Actions are down 😂 https://www.githubstatus.com/
Github Actions are down 😂 https://www.githubstatus.com/
Well at least it isn't just us 😂
Lol worse status now:
kk, leave this PR until the checks run :)
Lets try this again!
Running!