search

sassoftware / ci360-download-client-python

ci360 data download client program using Python
Apache License 2.0
14 stars 11 forks source link

Update read_csv function calls to Pandas 2.0 api in function readResetRange #11

Open royalsouvenir opened 1 year ago

royalsouvenir commented 1 year ago

Pandas 2.0 which was released as GA in April removed the error_bad_lines parameter from read_csv. The function readResetRange uses this parameter which generates an error when calling due to the api change in Pandas. The function needs to be changed to remove the error_bad_lines argument.

https://github.com/sassoftware/ci360-download-client-python/blob/90213642f3370a5a05966b0d14908d1757225bd8/discover.py#L636

Current workaround is to set pandas==1.5.2 when installing.

mkrsas commented 11 months ago

Thanks for this note and workaround. I found it also works with the most up to date version of pandas if you replace the error_bad_lines=True parameter with on_bad_lines='warn' in line 643