Improve properties resolution

sassoftware / pymaven

pymaven is a library for working with maven repositories via python. pymaven is not intended as a complete replacement of the maven build system, but instead as a way for python programs to fetch artifacts and artifact dependencies from maven2 repositories.

Apache License 2.0

14 stars 11 forks source link

Improve properties resolution #10

Open pombredanne opened 7 years ago

pombredanne commented 7 years ago

I have several examples of POms that use some not-yet fully supported properties resolutions:

with substrings: https://repo.maven.apache.org/maven2/commons-lang/commons-lang/2.1/commons-lang-2.1.pom
with group_id inherited from parent: https://repo.maven.apache.org/maven2/org/apache/activemq/activemq-camel/5.4.2/activemq-camel-5.4.2.pom

etc.

pombredanne commented 7 years ago

Now the things that tickles me is that there are eventually two approaches:

the current one which is to collect property values then resolve properties on actual specific data
another approach which is to collect property values and then apply then all at once on the text of the POM and reparsing it afterwards. This later may be simpler.... yes it may also be weird, inefficient or at odds with the cases where a POM is not built from XML. I guess I will stay with the first approach and I have code that handles it alright. ... I will try to plug this in the current code.

wfscheper commented 7 years ago

Could you extract the properties from those poms that don't work into some unit tests and open a PR? Then we can work on figuring out a fix.

Of course, you can always include your code that fixes them too.

pombredanne commented 7 years ago

@wfscheper Will do. Part of it is also about parent "inheritance", but I will keep it focused here only on properties for clarity and ease of review