search

sassoftware / pymaven

pymaven is a library for working with maven repositories via python. pymaven is not intended as a complete replacement of the maven build system, but instead as a way for python programs to fetch artifacts and artifact dependencies from maven2 repositories.
Apache License 2.0
14 stars 11 forks source link

Support Python 3 #14

Closed pombredanne closed 5 years ago

pombredanne commented 5 years ago

We are working on the Python3 port of Scancode and this library will need to be updated accordingly to support Python3.

For now there are issues such as https://github.com/sassoftware/pymaven/blob/b744bbe27d6418ee169c8f8718ce89f602e21b2a/pymaven/utils.py#L19

    from urlparse import urlsplit, urlunsplit
ModuleNotFoundError: No module named 'urlparse'
pombredanne commented 5 years ago

@wfscheper It looks like scancode and your tools are the only two users of pymaven so far. Are you still willing to maintain it? Otherwise I am fine ti take it over. Alternatively I can just maintain my fork too.

wfscheper commented 5 years ago

Whoops. Hit the wrong button. I'm taking at look what it will take to add python3 support.

wfscheper commented 5 years ago

So PR #13 adds python3 support, but I left it un-merged for you to review. Guess we both got busy with other things. Shall I merge that now?

pombredanne commented 5 years ago

@wfscheper let me quickly review this at last!

wfscheper commented 5 years ago

Fixed by #13