search

sassoftware / python-dlpy

The SAS Deep Learning Python (DLPy) package provides the high-level Python APIs to deep learning methods in SAS Visual Data Mining and Machine Learning. It allows users to build deep learning models using friendly Keras-like APIs.
Apache License 2.0
224 stars 131 forks source link

model.deploy to table and s.table.loadTable don't work well together #280

Open smatton opened 4 years ago

smatton commented 4 years ago

If I deploy a model to table using, model.deploy(path='/path/to/dir', output_format='table') it produces 3 tables

modelname.sashdat modelname_weights.sashdat modelname_weights_attr.sashdat

If I try to load these tables with

s.table.loadTable it will complain that it can't find modelname.ATTRS.sashdat , if I rename the attributes table to what it expects it will work.

modeldetect = s.table.loadTable(caslib='scz', path='detectmobile/Model_M43t70.sashdat', loadattrs=True) modeldetectname = s.table.loadTable(caslib='scz',casout={'name':'mobiledetect'}, path='detectmobile/Model_M43t70_weights.sashdat')

sasxianhu commented 4 years ago

Please use https://sassoftware.github.io/python-dlpy/generated/dlpy.model.Model.from_table.html#dlpy.model.Model.from_table

sasxianhu commented 4 years ago

or https://sassoftware.github.io/python-dlpy/generated/dlpy.model.Model.from_sashdat.html#dlpy.model.Model.from_sashdat

smatton commented 4 years ago

I can use those, but shouldn't the naming conventions be consistent across API's?

sasxianhu commented 4 years ago

When we shipped our DLPy APIs, loadTable did not support loadAttr. Unfortunately, save and loadTable later use different naming conventions. We don’t plan to break our APIs for now.

Best, XQ

Everyday is a new learning day.

From: Scott Matton notifications@github.com Sent: Wednesday, February 19, 2020 6:55:42 PM To: sassoftware/python-dlpy python-dlpy@noreply.github.com Cc: Xiangqian Hu Xiangqian.Hu@sas.com; Comment comment@noreply.github.com Subject: Re: [sassoftware/python-dlpy] model.deploy to table and s.table.loadTable don't work well together (#280)

EXTERNAL

I can use those, but shouldn't the naming conventions be consistent across API's?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsassoftware%2Fpython-dlpy%2Fissues%2F280%3Femail_source%3Dnotifications%26email_token%3DAJC6DO3PQ2XGRR5G56EYPZLRDXBH5A5CNFSM4KYD4EN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMKFUPY%23issuecomment-588536383&data=02%7C01%7Cxiangqian.hu%40sas.com%7Cf0fb409b55b2497190e208d7b5973b46%7Cb1c14d5c362545b3a4309552373a0c2f%7C0%7C0%7C637177533448257838&sdata=VgjmtZnAzMGxQzE%2BvvRHDXHseVh%2FLLbhLXN4sS9zUdM%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJC6DO3KJJ3QVD6MXZ63L2DRDXBH5ANCNFSM4KYD4ENQ&data=02%7C01%7Cxiangqian.hu%40sas.com%7Cf0fb409b55b2497190e208d7b5973b46%7Cb1c14d5c362545b3a4309552373a0c2f%7C0%7C0%7C637177533448267831&sdata=axfBfhWqu8B55XPynU%2BzxOY6ckB8CkbMiVbo%2FB8Nizs%3D&reserved=0.