search

sassoftware / python-dlpy

The SAS Deep Learning Python (DLPy) package provides the high-level Python APIs to deep learning methods in SAS Visual Data Mining and Machine Learning. It allows users to build deep learning models using friendly Keras-like APIs.
Apache License 2.0
224 stars 131 forks source link

ImageTable.from_table() fails if CASTable defined with replace= option #385

Closed jlwalke2 closed 1 year ago

jlwalke2 commented 1 year ago

This works as expected:

tableA = cas.CASTable("data")
dlpy.ImageTable.from_table(tableA)

This fails with the following message: 

tableB = cas.CASTable("data", replace=True)
dlpy.ImageTable.from_table(tableB)

ERROR: Parameter 'table.replace' is not recognized. ERROR: Expecting one of the following as a subparameter to 'table': name, caslib, where, computedVars, computedVarsProgram, computedOnDemand, singlePass, importOptions, onDemand, vars, dataSourceOptions, whereTable, compVars, compPgm, compOnDemand, import, options, dataSource.

The replace parameter is a valid (and useful) parameter for a swat.CASTable instance and should not cause DLPy to generate an error.

dxq77dxq commented 1 year ago

Hello, This error is from https://github.com/sassoftware/python-dlpy/blob/master/dlpy/images.py#L218. DLPy takes whatever parameter that is associated with tableB, but it's not recognized by table.partition(), which is at the action level.