sassoftware / python-sasctl

Python package and CLI for user-friendly integration with SAS Viya
https://sassoftware.github.io/python-sasctl
Apache License 2.0
45 stars 40 forks source link

Older examples needs to be updated for JSONFiles API changes #178

Open pebblehut opened 1 year ago

pebblehut commented 1 year ago

Describe the issue This example has some API calls that don't work with the updated version of sasctl - changes to JSONFiles: https://github.com/sassoftware/python-sasctl/blob/master/examples/pzmmCompleteModelExampleMLFlowSklearn.ipynb

For example, writeModelPropertiesJSON is now write_model_properties_json and has many changes in the parameters.

Other examples: writeFileMetadataJSON writeVarJSON

I checked other examples and it seems any of them 6 months or older are now out of date with the newer sasctl API.

To Reproduce Run this command using latest sasctl

J.writeVarJSON(inputsDict, isInput=True, jPath=zipFolder)

and you will get things like

AttributeError: 'JSONFiles' object has no attribute 'writeVarJSON'. Did you mean: 'write_var_json'?

Version The SHA is 729e72c8785065109ccfd1ffdb9816d4bf1dce55

SilvestriStefano commented 11 months ago

Hello, I was going through the notebook mentioned above and I noticed that more things have changed since sasctl v1.8.2:

also for each of those methods some parameters have a different name and use snake-case instead of camel-case. Moreover, the parameters of writeModelPropertiesJSON() used in the notebook do not all match the ones in write_model_properties_json() :

I will update if I find more.