Open pebblehut opened 1 year ago
Hello, I was going through the notebook mentioned above and I noticed that more things have changed since sasctl v1.8.2:
writeVarJSON()
has been renamed write_var_json()
;writeModelPropertiesJSON()
has been renamed write_model_properties_json()
; writeFileMetadataJSON()
has been renamed write_file_metadata_json()
;also for each of those methods some parameters have a different name and use snake-case instead of camel-case.
Moreover, the parameters of writeModelPropertiesJSON()
used in the notebook do not all match the ones in write_model_properties_json()
:
targetEvent:int
and numTargetCategories:int
do not exists anymore, I think they have been substituted with target_values:list
eventProbVar
i believe has also been removed because it is handled in the code directlymodelType
is now model_algorithm
modelPredictors
has been removedI will update if I find more.
Describe the issue This example has some API calls that don't work with the updated version of sasctl - changes to JSONFiles: https://github.com/sassoftware/python-sasctl/blob/master/examples/pzmmCompleteModelExampleMLFlowSklearn.ipynb
For example, writeModelPropertiesJSON is now write_model_properties_json and has many changes in the parameters.
Other examples: writeFileMetadataJSON writeVarJSON
I checked other examples and it seems any of them 6 months or older are now out of date with the newer sasctl API.
To Reproduce Run this command using latest sasctl
J.writeVarJSON(inputsDict, isInput=True, jPath=zipFolder)
and you will get things like
AttributeError: 'JSONFiles' object has no attribute 'writeVarJSON'. Did you mean: 'write_var_json'?
Version The SHA is 729e72c8785065109ccfd1ffdb9816d4bf1dce55