search

sassoftware / python-sasctl

Python package and CLI for user-friendly integration with SAS Viya
https://sassoftware.github.io/python-sasctl
Apache License 2.0
45 stars 41 forks source link

MLFlowModel rewrite #180

Closed SilvestriStefano closed 1 year ago

SilvestriStefano commented 1 year ago

Hello, this is a fix for issue #179 use yaml to read MLFlowModel file as suggested by user @pulungw

I ran the test test_mlflow_model.py and it passed.

I also ran the code in the notebook pulungw/sascode/python/mlflow_sample.ipynb and it worked fine. image

Signed-off-by: Stefano Silvestri ssilvestri@olab-studio.com

SilvestriStefano commented 1 year ago

Hi, sasctl already requires the pyyaml package :) https://github.com/sassoftware/python-sasctl/blob/7c7d9f1683c53bb69754121742706bd1a14d1a8f/setup.py#L45 which is then called for example in core.py : https://github.com/sassoftware/python-sasctl/blob/7c7d9f1683c53bb69754121742706bd1a14d1a8f/src/sasctl/core.py#L23

smlindauer commented 1 year ago

Good to know that I can sometimes read 😜.

If the reqs are already in place, then I am going forward with merging this.