Open pulungw opened 8 months ago
Hello,
I think I have found the issue: just like the stackTrace is saying, the target_index
arrives to the methods _predictions_to_metrics
and _binary_target
as None
because the default value set in the method write_score_code
is None
https://github.com/sassoftware/python-sasctl/blob/7c7d9f1683c53bb69754121742706bd1a14d1a8f/src/sasctl/pzmm/write_score_code.py#L38 and not 1
as stated in the documentation
https://github.com/sassoftware/python-sasctl/blob/7c7d9f1683c53bb69754121742706bd1a14d1a8f/src/sasctl/pzmm/write_score_code.py#L137
the other two methods (_predictions_to_metrics
and _binary_target
) do have a default value of 1
.
nevermind.... the very first two lines of _prediction_to_metrics
are
https://github.com/sassoftware/python-sasctl/blob/1018767a5d805e32a38abe1ba3eea2d0e5445904/src/sasctl/pzmm/write_score_code.py#L1156
https://github.com/sassoftware/python-sasctl/blob/1018767a5d805e32a38abe1ba3eea2d0e5445904/src/sasctl/pzmm/write_score_code.py#L1157
Describe the issue After updating sasctl to 1.10.1, I experienced TypeError when calling pzmm.ImportModel.import_model with the same code that used to work in 1.10.0.
To Reproduce Steps or example code to reproduce the issue.
The rest of my sample code can be found here: https://github.com/pulungw/sascode/blob/main/python/model_manager_register_sample_sklearn.ipynb Which was based from this article: https://blogs.sas.com/content/subconsciousmusings/2023/08/11/mlops-for-pirates-and-snakes/
Expected behavior pzmm.ImportModel.import_model finished execution succesfully like in 1.10.0.
Stack Trace If you're experiencing an exception, include the full stack trace and error message.
Version 1.10.1