sassoftware / python-sasctl

Python package and CLI for user-friendly integration with SAS Viya
https://sassoftware.github.io/python-sasctl
Apache License 2.0
46 stars 41 forks source link

Scoring code for H2O (binary) contains errors #189

Open zwyszomi opened 6 months ago

zwyszomi commented 6 months ago

I have built the H2O model based on the example: https://github.com/sassoftware/python-sasctl/blob/master/examples/pzmm_h2o_model_import.ipynb Then imported into Model Manager

There is one minor issue at this stage, when any Python developed model is imported with pzmm, in Model Manager the Score code file doesn't have the Score code attribute set. It has to be set manually which causes problems when CI/CD approach is considered

Let's continue with H2O model issue. When H2O model is imported as the Binary one the Score code function contains several errors: 1) The model load statement is model=h2o.load(). The load() method is not defined for h2o it should be load_model 2) The model path within model=h2o.load() statement is wrong. The model pickle file name should be placed into quotation marks 3) There are a few places with prediction variable comparison e.g. prediction[1][2] > 0.5. Prediction is defined as STR therefore it will generate an error. it should be casted into float using float()

Version 1.10.1