search

sassoftware / relic

Relic is a service and a tool for adding digital signatures to operating system packages for Linux and Windows
Apache License 2.0
151 stars 41 forks source link

Update code for more recent github.com/AzureAD/microsoft-authentication-library-for-go? #39

Closed jas4711 closed 7 months ago

jas4711 commented 7 months ago

Hi. I'm packaging relic for Debian, in order to get sigstore's rekor into Debian. We have github.com/AzureAD/microsoft-authentication-library-for-go in Debian but it is newer than you use, and causes the build error below. Could you update the dependency to the latest version of github.com/AzureAD/microsoft-authentication-library-for-go and fix your code?

# github.com/sassoftware/relic/cmdline/remotecmd
src/github.com/sassoftware/relic/cmdline/remotecmd/azure.go:65:20: cannot use &dvCache{…} (value of type *dvCache) as cache.ExportReplace value in argument to public.WithCache: *dvCache does not implement cache.ExportReplace (wrong type for method Export)
        have Export(cache.Marshaler, string)
        want Export(context.Context, cache.Marshaler, cache.ExportHints) error
src/github.com/sassoftware/relic/cmdline/remotecmd/azure.go:79:12: not enough arguments in call to s.cli.Accounts
    have ()
    want (context.Context)
src/github.com/sassoftware/relic/cmdline/remotecmd/azure.go:79:12: assignment mismatch: 1 variable but s.cli.Accounts returns 2 values
github.com/Azure/go-autorest/autorest/azure/auth

Thanks, Simon

mtharp commented 7 months ago

FIxed in v7.6.2