sassoftware / sas-container-recipes

A collection of recipes and other resources for building containers that include SAS Viya software.
https://www.sas.com
Apache License 2.0
89 stars 42 forks source link

ingress manifest remove static namespace entry #31

Open jameskochubasas opened 5 years ago

jameskochubasas commented 5 years ago

The generated ingress manifest contains a reference to the static namespace (verse other manifest don't give command flexibility) requiring the user to manually modify vs using the command option (-n or --namespace) to dynamically change based on K8S cluster namespace.

Recommend removing that property inside the generated file so the recommended output commands work: kubectl -n jakoch apply -f builds/full/manifests/kubernetes/ingress/sas-viya.yml && \ kubectl -n sas-viya apply -f builds/full/manifests/kubernetes/configmaps && \ kubectl -n sas-viya apply -f builds/full/manifests/kubernetes/secrets && \ kubectl -n sas-viya apply -f builds/full/manifests/kubernetes/services && \ kubectl -n sas-viya apply -f builds/full/manifests/kubernetes/deployments

If you don't remove that option and want to change namespace on command, it fails: kubectl -n jakoch apply -f ingress/sas-viya.yml --namespace=ssa-viya error: the namespace from the provided object "sas-viya" does not match the namespace "ssa-viya". You must pass '--namespace=sas-viya' to perform this operation.