search

sassoftware / saspy

A Python interface module to the SAS System. It works with Linux, Windows, and Mainframe SAS as well as with SAS in Viya.
https://sassoftware.github.io/saspy
Other
367 stars 149 forks source link

Function Definition Changes Needed for test_sasstat #515

Closed dmsenter89 closed 1 year ago

dmsenter89 commented 1 year ago

The file testsasstat.py requires some changes to the function definitions. Many of the included tests aren't run when using python3 -m unittest ... since the function names do not start with the `test` prefix. Examples include regResult1 through regResult4, and then from phregResult1. Several of the test names are also not informative of what test is being run. I propose changing the names of the non-running functions so that these tests will be included in unittesting.

I'm happy to work on this project and submit a PR when done.

tomweber-sas commented 1 year ago

Thanks @dmsenter89, yes, as we've seen there are a number of issues with that file and the tests. It would be great if you wanted to clean those up. I appreciate it! Thanks, Tom