search

sassoftware / saspy

A Python interface module to the SAS System. It works with Linux, Windows, and Mainframe SAS as well as with SAS in Viya.
https://sassoftware.github.io/saspy
Other
366 stars 149 forks source link

Typos in the documents #558

Closed shenzj1994 closed 10 months ago

shenzj1994 commented 10 months ago

Describe the bug There are a few typos in the SASpy documents: Link to Document

To Reproduce See screenshot below: image

Additional context For future reference, should we continue submit documentation issue in this repo or there is a better place for those?

tomweber-sas commented 10 months ago

Hey thanks! I can fix that. Yes, here is good for this. You can even open a PR with the fixes if you want. I can merge them in that way too. I'll fix this and rebuild the doc. Shouldn't take but a few minutes.

Thanks! Tom

tomweber-sas commented 10 months ago

I found a half dozen of that typo; cut-n-pasted in a bunch of places. Should all be fixed now!

tomweber-sas commented 10 months ago

Would you mind double checking that I got all of the ones you saw, and if so, we can close this? Thanks! Tom

shenzj1994 commented 10 months ago

Thank you @tomweber-sas . I think they are fixed. Did not realize there is a branch stored those HTML docs. Thanks for your reminder and I will do a PR in the future for those.

tomweber-sas commented 10 months ago

Actually, in this case, that doc is built from the source (this is the API doc). So, the changes actually went in the source code files, at main here. I just then build the doc and then I push the html to gh-pages. So, it depends upon where the doc picks up the text. The other doc is also here in the doc dir, in .rst files. So yeah, actually, all changes are here in main. Then I build the doc and push the resultant .html file to gh-pages. So, PR's here at main for any typos!