sassoftware / saspy

A Python interface module to the SAS System. It works with Linux, Windows, and Mainframe SAS as well as with SAS in Viya.
https://sassoftware.github.io/saspy
Other
366 stars 149 forks source link

Improved error message when calling 'symget' on a dead session. #573

Closed Sleemanmunk closed 5 months ago

Sleemanmunk commented 5 months ago

In the current version, symget gets an empty string and then crashes trying to convert it to an int. In this version it crashes with a helpful error message as to what happened including a guess at the cause that an end-user might understand (that the session is dead).

tomweber-sas commented 5 months ago

Hey Sam, thanks for contributing! One thing I'd like to tweak is the term 'dead'. I understand what that implies, but it's not quite a globally objective term. Could we use a more technical term, like the session may have 'terminated' that is more clear? The only other thing would be to add the 'sign off line' here in a comment, per the Contributor Agreement Thanks! Tom

tomweber-sas commented 5 months ago

All looks good. Merging, Thanks again Sam!