search

sassoftware / viya4-ark

SAS Viya Administration Resource Kit for Containerized Deployments. Tools and utilities to help SAS Customers with SAS Viya running in containers.
Apache License 2.0
34 stars 13 forks source link

Pre-install_check: Update Pre-Install Check based newer Viya4 Requirements Documentation (ls_issue_79) #144

Closed lasiva closed 3 years ago

lasiva commented 3 years ago

  1. Dropped code to validate individual nodes Memory and CPU for all nodes in cluster. Tool only checks for Aggregates capacity memory and capacity CPU of all nodes in the cluster. This dropped following keys in viya_deployment_settings.ini which resulted in refactoring interfaces:

    Minimum CPU of User node

    VIYA_GENERIC_WORKER_CPU=8

    Minimum Memory of User node expressed in Gi or Ki. Minimum value > 0 Gi/Ki

    VIYA_GENERIC_WORKER_MEMORY=32Gi

  2. Aggregate Memory and CPU are based on capacity of the node, the Allocatable memory or CPU. This resulted on refactoring a lot of variable names. It is based on capacity because kubectl cannot determine instance type.

  3. viya_cluster_settings.properties file replaced with viya_deployment_settings.ini which uses configparser

Please check README files for language and accuracy. Please check viya_deployment_settings.ini for consistency with README. Most code change are related to refactoring variable names.

FredPerrySAS commented 3 years ago

The "Memory and vCPU Check" header needs two or three hash marks to make it a header. I think that will fix the spacing problem in the section that follows.

Also, the following paragraph includes "SAS VIYA Operations document". Viya should not be in all caps.

AlissaSchleich commented 3 years ago

I looked over the readme and looked over the changes in the .ini files and they look good to me