Merge fix for issue 161 into develop

sassoftware / viya4-ark

SAS Viya Administration Resource Kit for Containerized Deployments. Tools and utilities to help SAS Customers with SAS Viya running in containers.

Apache License 2.0

33 stars 13 forks source link

Merge fix for issue 161 into develop #166

Closed sasjowood closed 2 years ago

cuddlehub commented 2 years ago

Why we need to remove the "ownerReferences" section?

kevinlinglesas commented 2 years ago

Guess I'm curious to now on the ownerReferences removal.

sasjowood commented 2 years ago

@cuddlehub, @kevinlinglesas, a large amount of unit tests were failing. The issue is that the ownerReferences in question all contained references to SASDeployment objects, but no SASDeployment mock files were ever added. Adding them would require quite a bit of changing and I believe the SASDeployment resource might be optional anyway, so it just wouldn't add any extra coverage or benefit to add that resource in unit tests.