sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
71 stars 64 forks source link

Add support for setting the namespaces for V4M logging and monitoring components #108

Closed dwstern closed 2 years ago

dwstern commented 3 years ago

https://github.com/sassoftware/viya4-deployment/blob/main/docs/CONFIG-VARS.md#monitoring-and-logging lists variables we can set in e.g. $HOME/project/deploy/${NS}/${NS}-viyavars.yaml, to customize the cluster-logging,cluster-monitoring and viya-monitoring components of SAS Viya Monitoring for Kubernetes. For example, we can use this file to set the Kibana and Grafana passwords (V4M_KIBANA_PASSWORD and V4M_GRAFANA_PASSWORD respectively), among many other thngs.

Please would you add a way to set the LOG_NS (logging namespace) and MON_NS (monitoring namespace) in this vars file too? These namespace names should not be hard-coded to 'logging' and 'monitoring' respectively; you can change them if you deploy SAS Viya Monitoring for Kubernetes the manual way.

thpang commented 2 years ago

Fixed here #143

dwstern commented 2 years ago

Fantastic news - thank you @thpang!