search

sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
71 stars 64 forks source link

Enable cluster-autoscaler on AWS #112

Closed NormJohnIV closed 3 years ago

NormJohnIV commented 3 years ago

Support deploying cluster autoscaler in aws

hahewlet commented 3 years ago

Need a reference in the readme to inheriting CLUSTER_AUTOSCALER_ACCOUNT from terrform.tfstate

hahewlet commented 3 years ago

@NormJohnIV the default region for the K8s cluster-autoscaler is us-east-1 as defined in https://github.com/kubernetes/autoscaler/blob/master/charts/cluster-autoscaler/values.yaml. Can viya4-deployment change that to match whatever region the cluster resides in?. For performance purposes that would been a good thing.

yes I can override that with CLUSTER_AUTOSCALER_LOCATION. Acting as the customer, I'd think hey I told viya4-iac-aws what region I wanted. I told viya4-deployment to use my terraform.tfstate file, so I expect my region choice to be honored.

Even if I BYO cluster, I'd be thrilled to see viya4-deployment detect my cluster region and ensure the cluster-autoscaler is set in the same place.

hahewlet commented 3 years ago

Testing completed signing off.